SERVER-137185ClosedDone

GenerateAndCheckPerfResults passes failed threshold checks when the override lookup errors

Since SERVER-136977, CheckPerfResultTestCase.run_test catches every exception other than ServerFailure and TestFailure, logs it, and lets the test pass. When a metric fails its threshold check on a PR or merge queue run, _check_thresholds looks up override comments through the GitHub API: get_pull, get_issue_comments, get_review_comments, and get_comments. An error from any of these calls is swallowed by run_test, so a confirmed regression with no authorized override is reported as passing. Bef

Affected Versions
Versions known to exhibit this issue

No affected versions recorded.

Fixed Versions
Versions that include the fix
9.1.0-rc09.1.0-rc1025
Components
Server components related to this issue

No components specified.

Labels
Tags and classification
perf-microbenchmarkperfinfra-bucket-operationsperfinfra-class-support